Skip to content

Use the target Python version when selecting benchmarks - #506

Merged
savannahostrowski merged 3 commits into
python:mainfrom
savannahostrowski:fix/target-python-benchmark-selection
Nov 20, 2026
Merged

savannahostrowski merged 3 commits into
python:mainfrom
savannahostrowski:fix/target-python-benchmark-selection

Conversation

@savannahostrowski

Copy link
Copy Markdown
Member

There seems to be a bug where benchmark selection checks requires-python against the interpreter running pyperformance, rather than the target specified by --python.

I noticed this while investigating benchmark coverage for https://doesjitgobrrr.com/. Sulaco’s results include eight async_tree_eager* benchmarks missing from Ripley’s results. Their harnesses run 3.12 and 3.11 respectively, despite both targeting CPython’s main branch.

This PR uses the target interpreter’s version for filtering and adds a regression test.

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks correct, can you please add it to the changelog?

Comment thread pyperformance/cli.py Resolved
Comment thread pyperformance/cli.py Resolved

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@savannahostrowski
savannahostrowski merged commit 1c80986 into python:main Nov 20, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants