Skip to content

gh-162342: Close cached zip files in importlib.metadata test fixtures - #162352

Merged
cmaloney merged 1 commit into
python:mainfrom
cmaloney:gh-162342-test-cleanup
Nov 21, 2026
Merged

cmaloney merged 1 commit into
python:mainfrom
cmaloney:gh-162342-test-cleanup

Conversation

@cmaloney

@cmaloney cmaloney commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Temporary workaround to get bots green until importlib.metadata cleans these up itself. FastPath keeps the fixture ZipFiles alive because of a cycle in its cache. That means they get closed on deallocation resulting in the unclosed file warning.

cc: @eendebakpt @kumaraditya303 This buildbot failure was introduced by #161184 which made it so a reference cycle in a cache in importlib.metadata was cleaned up slightly differently leading to the warning. Goal here is just to get bots back to green. Fixing the unclosed file is separate larger project.

…xtures

Temporary workaround to get bots green until importlib.metadata cleans
these up itself. FastPath keeps the fixture ZipFiles alive because of
a cycle in its cache. That means they get closed on deallocation
resulting in the unclosed file warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @cmaloney for commit f5e5158 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F162352%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 21, 2026
@cmaloney

cmaloney commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor Author

Merging to get bots green. Filed python/importlib_metadata#562 to fix the reference cycle.

@cmaloney
cmaloney merged commit e8fb673 into python:main Nov 21, 2026
118 of 123 checks passed
@cmaloney
cmaloney deleted the gh-162342-test-cleanup branch November 21, 2026 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants