Repository navigation
gh-162342: Close cached zip files in importlib.metadata test fixtures - #162352
Merged
Merged
Conversation
…xtures Temporary workaround to get bots green until importlib.metadata cleans these up itself. FastPath keeps the fixture ZipFiles alive because of a cycle in its cache. That means they get closed on deallocation resulting in the unclosed file warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
🤖 New build scheduled with the buildbot fleet by @cmaloney for commit f5e5158 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F162352%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Contributor
Author
|
Merging to get bots green. Filed python/importlib_metadata#562 to fix the reference cycle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary workaround to get bots green until importlib.metadata cleans these up itself. FastPath keeps the fixture ZipFiles alive because of a cycle in its cache. That means they get closed on deallocation resulting in the unclosed file warning.
cc: @eendebakpt @kumaraditya303 This buildbot failure was introduced by #161184 which made it so a reference cycle in a cache in
importlib.metadatawas cleaned up slightly differently leading to the warning. Goal here is just to get bots back to green. Fixing the unclosed file is separate larger project.