From 5041b6311fee9080190772a6a34e783e08734920 Mon Sep 17 00:00:00 2001 From: harryfoster2006 Date: Wed, 18 Nov 2026 16:16:47 +0000 Subject: [PATCH 1/2] fix: parse WITH NO SCHEMA BINDING on CREATE VIEW Redshift late-binding views end with WITH NO SCHEMA BINDING. Accept the clause after the view query, keep it on CreateView and deparse it. Co-Authored-By: Claude Sonnet 5.5 --- .../statement/create/view/CreateView.java | 17 +++++++++++++++++ .../net/sf/jsqlparser/parser/JSqlParserCC.jjt | 2 ++ .../create/RedshiftCreateViewTest.java | 11 +++++++++++ 3 files changed, 30 insertions(+) diff --git a/src/main/java/net/sf/jsqlparser/statement/create/view/CreateView.java b/src/main/java/net/sf/jsqlparser/statement/create/view/CreateView.java index 72e83f546d..102571f5ba 100644 --- a/src/main/java/net/sf/jsqlparser/statement/create/view/CreateView.java +++ b/src/main/java/net/sf/jsqlparser/statement/create/view/CreateView.java @@ -51,6 +51,7 @@ public void appendMySqlOptionsTo(StringBuilder builder) { private AutoRefreshOption autoRefresh = AutoRefreshOption.NONE; private Boolean backup; private boolean withReadOnly = false; + private boolean withNoSchemaBinding = false; private boolean ifNotExists = false; private List viewCommentOptions = null; private boolean recursive; @@ -265,6 +266,19 @@ public void appendMaterializationOptionsTo(StringBuilder sql) { } } + public boolean isWithNoSchemaBinding() { + return withNoSchemaBinding; + } + + public void setWithNoSchemaBinding(boolean withNoSchemaBinding) { + this.withNoSchemaBinding = withNoSchemaBinding; + } + + public CreateView withWithNoSchemaBinding(boolean withNoSchemaBinding) { + this.setWithNoSchemaBinding(withNoSchemaBinding); + return this; + } + public boolean isWithReadOnly() { return withReadOnly; } @@ -361,6 +375,9 @@ public void appendOptionsAfterQueryTo(StringBuilder sql) { if (withData != null) { sql.append(withData ? " WITH DATA" : " WITH NO DATA"); } + if (withNoSchemaBinding) { + sql.append(" WITH NO SCHEMA BINDING"); + } } private void appendForceOptionIfApplicable(StringBuilder sql) { diff --git a/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt b/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt index 08ae097a63..fd9f71c2ea 100644 --- a/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt +++ b/src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt @@ -24636,6 +24636,8 @@ CreateView CreateView(boolean isUsingOrReplace): ( { createView.setWithReadOnly(true); } | + LOOKAHEAD(2) ContextualKeyword("BINDING") { createView.setWithNoSchemaBinding(true); } + | checkOption=ViewCheckOption() { createView.setCheckOption(checkOption); } | withData=DataPopulation() { createView.setWithData(withData); } diff --git a/src/test/java/net/sf/jsqlparser/statement/create/RedshiftCreateViewTest.java b/src/test/java/net/sf/jsqlparser/statement/create/RedshiftCreateViewTest.java index d5346390da..76d5537a5e 100644 --- a/src/test/java/net/sf/jsqlparser/statement/create/RedshiftCreateViewTest.java +++ b/src/test/java/net/sf/jsqlparser/statement/create/RedshiftCreateViewTest.java @@ -79,4 +79,15 @@ void backupRemainsAnIdentifier() throws JSQLParserException { "CREATE MATERIALIZED VIEW backup BACKUP YES AS SELECT backup FROM backup"); TestUtils.assertSqlCanBeParsedAndDeparsed("SELECT backup FROM backup"); } + + @Test + void lateBindingView() throws JSQLParserException { + TestUtils.assertSqlCanBeParsedAndDeparsed( + "CREATE VIEW v AS (SELECT a FROM t) WITH NO SCHEMA BINDING"); + TestUtils.assertSqlCanBeParsedAndDeparsed( + "CREATE OR REPLACE VIEW s.v (a) AS SELECT a FROM s.t WITH NO SCHEMA BINDING"); + CreateView view = (CreateView) CCJSqlParserUtil + .parse("CREATE VIEW v AS SELECT 1 WITH NO SCHEMA BINDING"); + assertTrue(view.isWithNoSchemaBinding()); + } } From b3749ea51982329214491e5c668cce2523ac4643 Mon Sep 17 00:00:00 2001 From: harryfoster2006 Date: Fri, 20 Nov 2026 17:44:59 +0000 Subject: [PATCH 2/2] chore: move getMySqlOptions below all field declarations --- .../statement/create/view/CreateView.java | 29 +++++++++---------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/src/main/java/net/sf/jsqlparser/statement/create/view/CreateView.java b/src/main/java/net/sf/jsqlparser/statement/create/view/CreateView.java index 102571f5ba..ff8558b771 100644 --- a/src/main/java/net/sf/jsqlparser/statement/create/view/CreateView.java +++ b/src/main/java/net/sf/jsqlparser/statement/create/view/CreateView.java @@ -25,21 +25,6 @@ public class CreateView extends ASTNodeAccessImpl implements Statement { private MySqlViewOptions mySqlOptions; - - public MySqlViewOptions getMySqlOptions() { - return mySqlOptions; - } - - public void setMySqlOptions(MySqlViewOptions mySqlOptions) { - this.mySqlOptions = mySqlOptions; - } - - public void appendMySqlOptionsTo(StringBuilder builder) { - if (mySqlOptions != null) { - mySqlOptions.appendTo(builder); - } - } - private Table view; private Select select; private boolean orReplace = false; @@ -68,6 +53,20 @@ public enum CheckOption { DEFAULT, LOCAL, CASCADED } + public MySqlViewOptions getMySqlOptions() { + return mySqlOptions; + } + + public void setMySqlOptions(MySqlViewOptions mySqlOptions) { + this.mySqlOptions = mySqlOptions; + } + + public void appendMySqlOptionsTo(StringBuilder builder) { + if (mySqlOptions != null) { + mySqlOptions.appendTo(builder); + } + } + public boolean isRecursive() { return recursive; }